Break circular dependency between memory and runner packages #2000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
@commontools/memoryand@commontools/runnerpackages had a circular dependency:JSONValue,SchemaContext, andSchemaPathSelectorfrom@commontools/runner@commontools/memory/interfaceThis circular dependency caused:
Solution
Moved two simple type definitions from runner to memory:
SchemaContext- wraps two JSONSchema fieldsSchemaPathSelector- wraps path + optional SchemaContextThese types conceptually belong in memory as they're used in memory's query interface (
SchemaSelector).Changes
SchemaContextandSchemaPathSelectorlocally, importJSONSchemafrom@commontools/apiinstead of runnerSchemaContextfrom memorySchemaContextandSchemaPathSelectorfrom memoryImpact
Performance Improvements
Before vs After
cancel.ts (simple utility):
memory/interface.ts:
@commontools/runner→ circular dependencymerkle-referenceand@commontools/api→ no circle ✅Testing
All packages typecheck successfully:
🤖 Generated with Claude Code
Summary by cubic
Broke the circular dependency between @commontools/memory and @commontools/runner by moving SchemaContext and SchemaPathSelector to memory. This cuts typecheck overhead and speeds up runner builds.
Refactors
Performance
Written for commit 2a8c720. Summary will update automatically on new commits.